You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Mar 4, 2020. It is now read-only.
@kuzhelov: The implementation used in the Popup and the MenuItem for subscribing to EventStack has one subtle problem: although it solves the issue of item being opened and closed within the same frame, it also opens possibility for the following behavior:
MenuItem has opened submenu, this opened prop value doesn't change anyhow for the next JS frame.
///------ JS FRAME --------////
render method was called (but submenuOpen wasn't changed changed anyhow, it is still true)
updateOutsideClickSubscription
this.outsideClickSubscription.unsubscribe(), no subscription on outside click (!!)
setTimeout(() => subscription will be made on the next frame)
... some other logic ..
note, there is no click subscription at this moment, but it should be (!!)
////---------------------------////
Would suggest to leave a fix for a separate PR, for both components.