Skip to content

Call find_package(PEGTL) implicitly from find_package(cppgraphqlgen CONFIG) #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 15, 2023
Merged

Call find_package(PEGTL) implicitly from find_package(cppgraphqlgen CONFIG) #289

merged 2 commits into from
May 15, 2023

Conversation

wravery
Copy link
Contributor

@wravery wravery commented May 15, 2023

Fix #288. All targets of cppgraphqlgen depend on PEGTL, so that should be formalized in the CMake package config file.

@wravery wravery merged commit 00a6d4b into microsoft:main May 15, 2023
@wravery wravery deleted the find-pegtl branch May 15, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using find_package(cppgraphqlgen) does not implicitly invoke find_package(pegtl)
1 participant
@wravery