Skip to content

Fix #265 #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 6, 2022
Merged

Fix #265 #266

merged 3 commits into from
Jun 6, 2022

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Jun 6, 2022

The static const s_valuesEnumName array which clientgen emits must be sorted on the name using internal::shorter_or_less to use the internal::sorted_map_lookup constexpr function.

@wravery wravery merged commit e652672 into microsoft:main Jun 6, 2022
@wravery wravery deleted the sort-clientgen-enums branch June 6, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wravery