Add constexpr support to internal::sorted_map and internal::sorted_set #237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #139
Unfortunately,
constexpr
support forstd::vector
seems to be lagging behind in GCC and AppleClang, so I was only able to do this by extracting some of the lookup logic an templatizing it on the container and iterator types ininternal::sorted_map_equal_range
andinternal::sorted_map_lookup
. That way it can apply the same logic to perform lookups against astd::array<std::pair<K, V>>
as it would for aninternal::sorted_map<K, V>
.The only place where I've actually adopted this is in the generated enum value maps, but this should make looking up an enum value
O(log(n))
instead ofO(n)
at runtime. It also lets you perform compile time mapping between the strings and their enum values.