More constexpr schema #227
Conversation
|
|
Yes, please do push another commit with the regenerated files. That will help me to review the changes since I can see what they look like in context. |
src/SchemaGenerator.cpp
Outdated
| @@ -146,6 +146,12 @@ static_assert(graphql::internal::MinorVersion == )cpp" | |||
| } | |||
| } | |||
|
|
|||
| headerFile << R"cpp( | |||
|
|
|||
| using namespace std::literals; | |||
There was a problem hiding this comment.
I'd prefer not to add a using namespace statement in the header, although this is at least scoped to the generated namespace. Consider leaving this out and wrapping the string literals in explicit std::string_view constructors, like in static_typename instead of appending the sv literal operator.
It looks like this is copied from the sourceFile generation. Could the sourceFile use this instead of declaring its own std::array? Or could the entire mapping function be made constexpr and moved to the header? Then you could also keep the using namespace std::literals; but in the scope of the constexpr function.
| @@ -173,6 +179,30 @@ static_assert(graphql::internal::MinorVersion == )cpp" | |||
| }; | |||
|
|
|||
| )cpp"; | |||
| firstValue = true; | |||
|
|
|||
| headerFile << R"cpp(constexpr std::array<std::string_view, )cpp" | |||
There was a problem hiding this comment.
It looks like we don't necessarily include <array> or <string_view> with this header. The PR build failed on Windows saying that those types were undefined. If we want to move this to the header, I think you'll also need to add those #include directives to the headerFile preamble.
There was a problem hiding this comment.
Will fix up. Apologies - I only have a Linux set of machines to run the tests on here.
|
Sorry it took a while to get back to this - passes Windows checks now, and consolidated the array references to one constexpr declaration |
Adds a few extra constexpr elements to the schemagen generated code - these elements help allow other compile time libs like Boost Hana to do more operations on the schema (ie: type-based dispatch using a constexpr
std::string_viewto aboost::hana::type_c<T>for more generic code)This does modify the generated example schema files (ie:
introspectionand friends) - I can resubmit this with the updates committed.