-
Couldn't load subscription status.
- Fork 2.5k
Closed
Labels
Area: SkillsThe issue is related to skillsThe issue is related to skillsP1Painful if we don't fix, won't block releasingPainful if we don't fix, won't block releasingSize: SThe issue is simple and well understood, it will take a day or less to completeThe issue is simple and well understood, it will take a day or less to completebugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.
Description
Version
4.10.3
Describe the bug
When a skill calls back to the skill host the skill host creates a "ContinueConversation" event activity to get back into the context of the conversation. This is essentially a temporary internal activity, but the TranscriptLogger is writing it to the transcript. I don't think we want it logged to the transcript.
To Reproduce
Look at logs when using skills
Expected behavior
I think we shouldn't log it. We need to add logic to exclude internal skill messages from TranscriptLoggerMiddleware like we do in the TanscriptLogger sample.
Tracking Status
Dotnet SDK 4733
- PR
- Merged
Javascript SDK 2805
- PR
- Merged
Python SDK 1393
- PR
- Merged
Java SDK 807
- PR
- Merged
Metadata
Metadata
Assignees
Labels
Area: SkillsThe issue is related to skillsThe issue is related to skillsP1Painful if we don't fix, won't block releasingPainful if we don't fix, won't block releasingSize: SThe issue is simple and well understood, it will take a day or less to completeThe issue is simple and well understood, it will take a day or less to completebugIndicates an unexpected problem or an unintended behavior.Indicates an unexpected problem or an unintended behavior.