Skip to content

Fix teams connector client creation credential retrieval bug #844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2020
Merged

Fix teams connector client creation credential retrieval bug #844

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions libraries/botbuilder-core/botbuilder/core/teams/teams_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,12 @@ async def get_members(turn_context: TurnContext) -> List[TeamsChannelAccount]:
async def get_teams_connector_client(
turn_context: TurnContext,
) -> TeamsConnectorClient:
# A normal connector client is retrieved in order to use the credentials
# while creating a TeamsConnectorClient below
connector_client = await TeamsInfo._get_connector_client(turn_context)

return TeamsConnectorClient(
turn_context.adapter._credentials, # pylint: disable=protected-access
turn_context.activity.service_url,
connector_client.config.credentials, turn_context.activity.service_url,
)

@staticmethod
Expand Down