emolsh/api-ref-docs-componentdialog #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2020 13:49
- Formatting issues start at line 197
- comments not showing, can't find error
- ? where I didn't know what to put for that section (feel free to edit/suggest correct content)
mmiele
approved these changes
Jan 23, 2020
Contributor
mmiele
left a comment
mmiele
left a comment
There was a problem hiding this comment.
It looks good.
When you say """ (not sure where to put this information)
Containers are typically leaf nodes on the stack but the dev is free to push other dialogs …
I would suggest to use this syntax:
.. note::
Containers are typically leaf nodes on the stack but the dev is free to push other dialogs …
See https://review.docs.microsoft.com/en-us/help/onboard/admin/reference/python/documenting-api?branch=master#note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.