Skip to content

emolsh/api-ref-docs-dialogstate #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 27, 2020
Merged

emolsh/api-ref-docs-dialogstate #621

merged 3 commits into from
Jan 27, 2020

Conversation

@emgrol
Copy link
Contributor

@emgrol emgrol commented Jan 20, 2020

No description provided.

@emgrol emgrol added the WIP label Jan 20, 2020
@emgrol emgrol requested review from axelsrz and mmiele January 20, 2020 19:20
@emgrol emgrol self-assigned this Jan 20, 2020
@emgrol
Updated formatting
c1cb806 
Not sure how to document method on line 36
@emgrol emgrol removed the WIP label Jan 23, 2020
@emgrol emgrol marked this pull request as ready for review January 23, 2020 19:10
mmiele
mmiele approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@mmiele mmiele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think def str(self):
Is internal and does not have to be documented.

@emgrol
Fixed formatting
9759e56 
Removed docstring for `def __str__(self)`
@tracyboehrer tracyboehrer merged commit 994df88 into python-API-ref-docs Jan 27, 2020
@emgrol emgrol deleted the emolsh/api-ref-docs-dialogstate branch March 31, 2020 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axelsrz axelsrz Awaiting requested review from axelsrz

1 more reviewer

@mmiele mmiele mmiele approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@emgrol emgrol

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emgrol @mmiele @tracyboehrer