Skip to content

Conversation

@mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Dec 10, 2019

Fixes instances where item.get("e_tag") fails due to item not being a dict, but having the "e_tag" attribute. Also changed a few instances where this was working fine to match the new "style" of this fix:

e_tag = None
if isinstance(item, dict):
  e_tag = item.get("e_tag", None)
elif hasattr(item, "e_tag"):
  e_tag = item.e_tag

All current tests pass (with EMULATOR_RUNNING = True, of course)

@mdrichardson mdrichardson marked this pull request as ready for review December 10, 2019 22:05
@mdrichardson mdrichardson requested a review from axelsrz December 10, 2019 22:05
@axelsrz axelsrz merged commit 8a9d72d into microsoft:master Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants