Skip to content

updating conversation params to parity #490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2019
Merged

updating conversation params to parity #490

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6f040ed
updating conversation params
Virtual-Josh Dec 10, 2019
f66a6ab
Merge branch 'master' into josh/adapter
axelsrz Dec 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libraries/botbuilder-core/botbuilder/core/bot_framework_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ async def create_conversation(
)

# Create conversation
parameters = ConversationParameters(bot=reference.bot)
parameters = ConversationParameters(
bot=reference.bot, members=[reference.user], is_group=False
)
client = await self.create_connector_client(reference.service_url)

# Mix in the tenant ID if specified. This is required for MS Teams.
Expand Down