Conversation Update Scenario #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelsrz
requested changes
Nov 13, 2019
| ) | ||
|
|
||
| if ( | ||
| hasattr(turn_context.activity, "type") |
There was a problem hiding this comment.
I'm curious about the logic here: if the activity doesn't have a type attribute at all... should it pass? Because with this conditional is not gonna raise an error until it gets to line 34 and you try to access turn_context.activity.type
I believe that (and correct me if you had other intention) you're trying to validate that turn_context.activity.type exists and is not None, you can achieve that by
if not getattr(turn_context.activity, "type", None): ...(raise your error)
I don't remember if you did a similar validation in your past PR but please take a look to make sure.
There was a problem hiding this comment.
Will resolve this in a different PR
libraries/botbuilder-core/botbuilder/core/Teams/teams_activity_handler.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-core/botbuilder/core/Teams/teams_activity_handler.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-core/botbuilder/core/Teams/teams_activity_handler.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-core/botbuilder/core/Teams/teams_activity_handler.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-schema/botbuilder/schema/teams/teams_channel_account.py
Show resolved
Hide resolved
libraries/botbuilder-schema/botbuilder/schema/teams/teams_channel_data.py
Show resolved
Hide resolved
libraries/botbuilder-schema/botbuilder/schema/teams/teams_channel_data.py
Show resolved
Hide resolved
libraries/botbuilder-schema/botbuilder/schema/teams/teams_channel_data.py
Outdated
Show resolved
Hide resolved
libraries/botbuilder-schema/botbuilder/schema/teams/tenant_info.py
Outdated
Show resolved
Hide resolved
axelsrz
approved these changes
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.