Skip to content

Fix ChoicePrompt ListStyle.none when set via PromptOptions #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 5, 2019
Merged

Fix ChoicePrompt ListStyle.none when set via PromptOptions #373

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9c2d66b
fix ChoicePrompt none style when set via options
Oct 28, 2019
d22885c
black compat
Oct 29, 2019
6f8e425
Merge branch 'master' into choicePromptStyle
mdrichardson Oct 29, 2019
86163b2
Merge branch 'master' into choicePromptStyle
mdrichardson Oct 31, 2019
68ae4c3
Merge branch 'master' into choicePromptStyle
tracyboehrer Nov 1, 2019
4040593
Merge branch 'master' into choicePromptStyle
cleemullins Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/choice_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,9 @@ async def on_prompt(
if self.choice_options
else ChoicePrompt._default_choice_options[culture]
)
choice_style = options.style if options.style else self.style
choice_style = (
0 if options.style == 0 else options.style if options.style else self.style
)

if is_retry and options.retry_prompt is not None:
prompt = self.append_choices(
Expand Down