Skip to content

Conversation

@axelsrz
Copy link
Member

@axelsrz axelsrz commented Oct 14, 2019

Inspection Middleware leveraging jsonpickle.

fixes #334

@axelsrz axelsrz requested review from daveta and johnataylor October 14, 2019 20:10
@axelsrz axelsrz closed this Oct 14, 2019
@axelsrz axelsrz reopened this Oct 14, 2019
result = (
default_value_or_factory()
if callable(default_value_or_factory)
else deepcopy(default_value_or_factory)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@daveta
Copy link
Contributor

daveta commented Oct 15, 2019

packages=["botbuilder.core", "botbuilder.core.adapters"],

inspection.


Refers to: libraries/botbuilder-core/setup.py:34 in 927a736. [](commit_id = 927a736, deletion_comment = False)

@axelsrz
Copy link
Member Author

axelsrz commented Oct 15, 2019

packages=["botbuilder.core", "botbuilder.core.adapters"],

inspection.

Refers to: libraries/botbuilder-core/setup.py:34 in 927a736. [](commit_id = 927a736, deletion_comment = False)

Done

Copy link
Contributor

@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@axelsrz axelsrz merged commit 392a5d4 into master Oct 15, 2019
@axelsrz axelsrz deleted the axsuarez/inspeciton branch October 15, 2019 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port Inspection Middleware

3 participants