[Parity w/ Dotnet] create_conversation tentant_id/channel_data #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
September 17, 2019 09:42
|
@axelsrz Can you take a quick look? |
axelsrz
reviewed
Sep 17, 2019
axelsrz
approved these changes
Sep 17, 2019
|
Because this a fork PR it won't trigger the coverage. I'm merging manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parity:
Keeps tentant_id & channel_data in create_conversation
I'm not confident I wrote the test appropriately. It works, but I'm not sure I went about it the best way. Let me know if you'd like something changed.
Before Change
After Change
