Skip to content

Conversation

@gurvsing
Copy link
Contributor

Multi-turn support for python

@Zerryth
Copy link
Contributor

Zerryth commented Aug 21, 2019

@trojenguri its build is failing on linting issues

Please pip install black and pylint, then run the following commands on your code from root of repo:

  • black libraries
  • pylint --rcfile=.pylintrc libraries

so that it'll auto-format your code to the repo's rules and also give you the linting errors that'll need to be fixed for the build to pass:

image

Copy link
Contributor

@Zerryth Zerryth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR! Excited for the multi-turn feature to be folded into the SDKs

Mostly just linting issues that need to be addressed. Also feel more comfortable if @axelsrz , our Python repo champion, takes a look at the PR as well.

@gurvsing gurvsing requested a review from Zerryth August 22, 2019 11:47
Copy link
Member

@axelsrz axelsrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @trojenguri nice PR! I would like to merge this whenever @cleemullins takes the C# and JS ones.

@cleemullins cleemullins self-requested a review August 27, 2019 17:30
Copy link
Contributor

@cleemullins cleemullins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please increase code coverage metrics.

@axelsrz axelsrz dismissed stale reviews from Zerryth and cleemullins August 29, 2019 17:53

changes addressed

@axelsrz axelsrz merged commit 31dd7ac into master Aug 29, 2019
@axelsrz axelsrz deleted the gurvsing/multiturn branch August 29, 2019 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants