Skip to content

Fixed retry prompting in NumberPrompt by adding await #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2019
Merged

Fixed retry prompting in NumberPrompt by adding await #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cd359f1
Fixed retry prompting in NumberPrompt by adding await
Zerryth Aug 15, 2019
693c83c
ran black on libraries
Zerryth Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/botbuilder-dialogs/botbuilder/dialogs/prompts/number_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ async def on_prompt(
raise TypeError("NumberPrompt.on_prompt(): options cannot be None.")

if is_retry and options.retry_prompt is not None:
turn_context.send_activity(options.retry_prompt)
await turn_context.send_activity(options.retry_prompt)
elif options.prompt is not None:
await turn_context.send_activity(options.prompt)

Expand Down
29 changes: 11 additions & 18 deletions libraries/botbuilder-dialogs/tests/test_number_prompt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,6 @@ async def exec_test(turn_context: TurnContext) -> None:
test_flow4 = await test_flow3.send("Give me twenty meters of cable")
await test_flow4.assert_reply("You asked me for '20' meters of cable.")

# TODO: retry_prompt in NumberPrompt appears to be broken
# It when NumberPrompt fails to receive a number, it retries, prompting
# with the prompt and not retry prompt in options
async def test_number_prompt_retry(self):
async def exec_test(turn_context: TurnContext) -> None:
dialog_context: DialogContext = await dialogs.create_context(turn_context)
Expand Down Expand Up @@ -161,14 +158,11 @@ async def exec_test(turn_context: TurnContext) -> None:
dialogs.add(number_prompt)

step1 = await adapter.send("hello")
await step1.assert_reply("Enter a number.")
# TODO: something is breaking in the validators or retry prompt
# where it does not accept the 2nd answer after reprompting the user
# for another value
# step3 = await step2.send("hello")
# step4 = await step3.assert_reply("You must enter a number.")
# step5 = await step4.send("64")
# await step5.assert_reply("Bot received the number '64'.")
step2 = await step1.assert_reply("Enter a number.")
step3 = await step2.send("hello")
step4 = await step3.assert_reply("You must enter a number.")
step5 = await step4.send("64")
await step5.assert_reply("Bot received the number '64'.")

async def test_number_uses_locale_specified_in_constructor(self):
# Create new ConversationState with MemoryStorage and register the state as middleware.
Expand Down Expand Up @@ -272,13 +266,12 @@ async def validator(prompt_context: PromptValidatorContext):

step1 = await adapter.send("hello")
step2 = await step1.assert_reply("Enter a number.")
await step2.send("150")
# TODO: something is breaking in the validators or retry prompt
# where it does not accept the 2nd answer after reprompting the user
# for another value
# step4 = await step3.assert_reply("You must enter a positive number less than 100.")
# step5 = await step4.send("64")
# await step5.assert_reply("Bot received the number '64'.")
step3 = await step2.send("150")
step4 = await step3.assert_reply(
"You must enter a positive number less than 100."
)
step5 = await step4.send("64")
await step5.assert_reply("Bot received the number '64'.")

async def test_float_number_prompt(self):
async def exec_test(turn_context: TurnContext) -> None:
Expand Down