Skip to content

Added SeverityEnum #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 9, 2019
Merged

Added SeverityEnum #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4f0ef9
Added SeverityEnum
axelsrz Aug 9, 2019
7727147
Merge branch 'master' into axsuarez/severity-enum
axelsrz Aug 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...plicationinsights/botbuilder/applicationinsights/application_insights_telemetry_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
from applicationinsights import TelemetryClient # pylint: disable=no-name-in-module
from botbuilder.core.bot_telemetry_client import (
BotTelemetryClient,
Severity,
TelemetryDataPointType,
)
from .integration_post_data import IntegrationPostData
Expand Down Expand Up @@ -168,7 +169,7 @@ def track_metric(
)

def track_trace(
self, name: str, properties: Dict[str, object] = None, severity=None
self, name: str, properties: Dict[str, object] = None, severity: Severity = None
):
"""
Sends a single trace statement.
Expand Down
3 changes: 2 additions & 1 deletion libraries/botbuilder-core/botbuilder/core/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
from .bot_framework_adapter import BotFrameworkAdapter, BotFrameworkAdapterSettings
from .bot_state import BotState
from .bot_state_set import BotStateSet
from .bot_telemetry_client import BotTelemetryClient
from .bot_telemetry_client import BotTelemetryClient, Severity
from .card_factory import CardFactory
from .conversation_state import ConversationState
from .intent_score import IntentScore
Expand Down Expand Up @@ -57,6 +57,7 @@
"NullTelemetryClient",
"Recognizer",
"RecognizerResult",
"Severity",
"ShowTypingMiddleware",
"StatePropertyAccessor",
"StatePropertyInfo",
Expand Down
10 changes: 9 additions & 1 deletion libraries/botbuilder-core/botbuilder/core/bot_telemetry_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,14 @@
from enum import Enum


class Severity(Enum):
verbose = 0
information = 1
warning = 2
error = 3
critical = 4


class TelemetryDataPointType(Enum):
measurement = 0
aggregation = 1
Expand Down Expand Up @@ -105,7 +113,7 @@ def track_metric(
)

@abstractmethod
def track_trace(self, name, properties=None, severity=None):
def track_trace(self, name, properties=None, severity: Severity = None):
"""
Sends a single trace statement.
:param name: the trace statement.\n
Expand Down
4 changes: 2 additions & 2 deletions libraries/botbuilder-core/botbuilder/core/null_telemetry_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

import traceback
from typing import Dict
from .bot_telemetry_client import BotTelemetryClient, TelemetryDataPointType
from .bot_telemetry_client import BotTelemetryClient, TelemetryDataPointType, Severity


class NullTelemetryClient(BotTelemetryClient):
Expand Down Expand Up @@ -90,7 +90,7 @@ def track_metric(
"""
return

def track_trace(self, name, properties=None, severity=None):
def track_trace(self, name, properties=None, severity: Severity = None):
"""
Sends a single trace statement.
:param name: the trace statement.\n
Expand Down