Skip to content

fix for accepting_input #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2019
Merged

fix for accepting_input #246

merged 1 commit into from
Jul 10, 2019

Conversation

@axelsrz
Copy link
Member

@axelsrz axelsrz commented Jul 10, 2019 •
edited
Loading

Oauth prompt should default the input hint to accepting_input not expecting_input

@axelsrz axelsrz requested a review from stevengum July 10, 2019 00:47
stevengum
stevengum approved these changes Jul 10, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests? Otherwise looks fine

@axelsrz axelsrz merged commit c0b24f0 into 4.5 Jul 10, 2019
@axelsrz axelsrz deleted the axsuarez/oauth-prompt-input-fix branch July 10, 2019 00:59
This was referenced Jul 11, 2019
Closed
Merged
axelsrz added a commit that referenced this pull request Jul 11, 2019
@axelsrz
tests for fix #246
dba96f9
axelsrz added a commit that referenced this pull request Jul 11, 2019
@axelsrz
4.5 cherry pick (#250)
78e7431 
* fix for accepting_input

* Axsuarez/corebot updates (#249)

* tests for pr #246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stevengum stevengum stevengum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@axelsrz @stevengum