Skip to content

Axsuarez/storage and bot state #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 3, 2019
Merged

Axsuarez/storage and bot state #236

merged 9 commits into from
Jul 3, 2019

Conversation

@axelsrz
Copy link
Member

@axelsrz axelsrz commented Jul 2, 2019

This PR contians:

  • updated functionality for cosmosdb storage to have parity with c# and javascript
  • changed behavior of StoreItem to not enforce e_tag validation

fixes #184 , fixes #97

daveta
daveta approved these changes Jul 3, 2019
View reviewed changes
Copy link
Contributor

@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@axelsrz axelsrz merged commit be59bf5 into master Jul 3, 2019
@axelsrz axelsrz deleted the axsuarez/storage-and-bot-state branch July 3, 2019 00:15
@stevengum stevengum added the 4.5 label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnataylor johnataylor Awaiting requested review from johnataylor

@stevengum stevengum Awaiting requested review from stevengum

@carlosscastro carlosscastro Awaiting requested review from carlosscastro

1 more reviewer

@daveta daveta daveta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Porting CosmosDB BotState should be POCO

4 participants

@axelsrz @daveta @stevengum