Skip to content

Conversation

@daveta
Copy link
Contributor

@daveta daveta commented Jun 26, 2019

  • async fix in aux_func for Django
  • Move loop to be global

@daveta daveta requested review from axelsrz, stevengum and tsuwandy June 26, 2019 18:05
Copy link
Contributor

@tsuwandy tsuwandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dave!!

@daveta daveta merged commit eed07a2 into master Jun 26, 2019
@daveta daveta deleted the daveta-django-fix branch June 26, 2019 18:57
@stevengum stevengum added the 4.5 label Jul 8, 2019
@viperfx
Copy link

viperfx commented Jun 5, 2020

hi there - I am not able to find django samples in this repo or the sample python repo (https://github.com/microsoft/BotBuilder-Samples/tree/master/samples)

Have they been moved elsewhere?

Any guidance on how to use async method, django and bot framework would be great.

@axelsrz
Copy link
Member

axelsrz commented Jun 5, 2020

Hello @viperfx , given that the framework heavily relies on asyncio syntax we no longer support django. We recommend you look into async frameworks like aiohttp or tornado.

@viperfx
Copy link

viperfx commented Jun 5, 2020

Hey @axelsrz thanks for the reply. Given that django is one of the most popular frameworks in python and it's very unlikely developers are going to run two different frameworks and libraries side by side for applications, it really would benefit the adoption of SDK framework to support what is currently the state of python ecosystem. The python3 adoption is good, but async I would say is still very early. Lot of database and ORM adapters do not support async right now, and still being actively worked on. All these pieces need to come together to make an application to serve end users.

Django has recently added support for Async - https://docs.djangoproject.com/en/3.0/topics/async/

But as you can see, there is a phased approach for adding full async support.

I would really encourage another look and adding some samples around how a non-async codebase in django could use bot framework, e.g. pre django 3.0, and if that is not possible, then adding a sample for django 3.0 onnwards with bot framework.

We have an existing solution in Teams that uses our internal SDK with REST APIs, but we are interested in using the bot framework too with our existing code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants