Skip to content

Conversation

@tsuwandy
Copy link
Contributor

No description provided.

@tsuwandy tsuwandy requested review from axelsrz and daveta June 19, 2019 18:03
@daveta
Copy link
Contributor

daveta commented Jun 19, 2019

@tsuwandy : It might be a good idea if we start out pylint clean (with exception of string length, which I regularly disable). I have to be honest, the code I checked in earlier was not clean. I just started this with the 201 sample. I can show you how to enable in vscode.

For the main bot class stuff, you can steal what I did in 201 (which should be the majority of the code).

Copy link
Contributor

@daveta daveta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@tsuwandy tsuwandy merged commit ac4fa17 into master Jun 21, 2019
@tsuwandy tsuwandy deleted the tiens branch June 21, 2019 18:53
@stevengum stevengum added the 4.5 label Jul 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants