Port: Set TeamsNotifyUser alert to opposite of alert_in_meeting #2185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracyboehrer
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223
Description
Porting changes from microsoft/botbuilder-dotnet#6136
The logic for
teams_notify_userhelper method is incorrect. It should set either alertInMeeting to true, or alert to true, but not both.botbuilder-python/libraries/botbuilder-core/botbuilder/core/teams/teams_activity_extensions.py
Lines 74 to 75 in 3e76e54
Specific Changes
Testing
The following image shows the related unit test passing.
