Port: Add settings.selectedChannel to TeamsChannelData and Type to ChannelInfo and TeamDetails #2173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nfo and TeamDetails
tracyboehrer
approved these changes
Sep 30, 2024
tracyboehrer
deleted the
v-gandiddi/Add_SelectedChannel_TeamsChannelData
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #minor
Description
This PR ports the changes from microsoft/botbuilder-dotnet#6360. It adds the ability to gather the selected MS Team's channel id when available in the incoming Activity.
Specific Changes
teams_get_selected_channel_idhelper function.TeamsChannelDataSettingsmodel and all its related properties to be accessible from the Activity.__init__.pyto include the new added properties.Testing
Below image shows the new unit tests passing.
