Skip to content

Fix for ConfigurationServiceClientCredentialFactory to allow auth disabled scenario #2135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Fix for ConfigurationServiceClientCredentialFactory to allow auth disabled scenario #2135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...aiohttp/botbuilder/integration/aiohttp/configuration_service_client_credential_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,13 +71,7 @@ def __init__(self, configuration: Any, *, logger: Logger = None) -> None:

# Default to MultiTenant
else:
if not app_id:
raise Exception("Property 'APP_ID' is expected in configuration object")
if not app_password:
raise Exception(
"Property 'APP_PASSWORD' is expected in configuration object"
)

# Specifically not checking for appId or password to allow auth disabled scenario
self._inner = PasswordServiceClientCredentialFactory(
app_id, app_password, None, logger=logger
)
Expand Down