Skip to content

#2040: fix usage of ResourceResponse to use named argument #2057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

#2040: fix usage of ResourceResponse to use named argument #2057

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libraries/botbuilder-core/botbuilder/core/cloud_adapter_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ async def send_activities(
)
)

response = response or ResourceResponse(activity.id or "")
response = response or ResourceResponse(id=activity.id or "")

responses.append(response)

Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-core/tests/simple_adapter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ async def update_activity(self, context: TurnContext, activity: Activity):
if self._call_on_update is not None:
self._call_on_update(activity)

return ResourceResponse(activity.id)
return ResourceResponse(id=activity.id)

async def process_request(self, activity, handler):
context = TurnContext(self, activity)
Expand Down
2 changes: 1 addition & 1 deletion libraries/botbuilder-core/tests/teams/simple_adapter_with_create_conversation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ async def update_activity(self, context: TurnContext, activity: Activity):
if self._call_on_update is not None:
self._call_on_update(activity)

return ResourceResponse(activity.id)
return ResourceResponse(id=activity.id)

async def process_request(self, activity, handler):
context = TurnContext(self, activity)
Expand Down