Skip to content

fix: cloudAdapter.update_conversation() add app_id parameter #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2023
Merged

fix: cloudAdapter.update_conversation() add app_id parameter #2037

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions libraries/botbuilder-core/botbuilder/core/cloud_adapter_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ async def continue_conversation( # pylint: disable=arguments-differ
self,
reference: ConversationReference,
callback: Callable,
bot_app_id: str,
):
"""
Sends a proactive message to a conversation.
Expand All @@ -161,9 +162,12 @@ async def continue_conversation( # pylint: disable=arguments-differ
:type reference: :class:`botbuilder.schema.ConversationReference`
:param callback: The method to call for the resulting bot turn.
:type callback: :class:`typing.Callable`
:param bot_app_id: The application Id of the bot. This is the appId returned by the Azure portal registration,
and is generally found in the `MicrosoftAppId` parameter in `config.py`.
:type bot_app_id: :class:`typing.str`
"""
return await self.process_proactive(
self.create_claims_identity(),
self.create_claims_identity(bot_app_id),
get_continuation_activity(reference),
None,
callback,
Expand All @@ -182,7 +186,7 @@ async def continue_conversation_with_claims(

async def create_conversation( # pylint: disable=arguments-differ
self,
bot_app_id: ConversationReference,
bot_app_id: str,
callback: Callable[[TurnContext], Awaitable] = None,
conversation_parameters: ConversationParameters = None,
channel_id: str = None,
Expand Down