Skip to content

Conversation

@daveta
Copy link
Contributor

@daveta daveta commented May 30, 2019

Creates a Flask + Application Insights sample based on Core-Bot

In particular:

  • Flask Middleware to perform post-body caching.
  • Fixes Application Insights Telemetry Processor. Add explicit return values for filtering, and add better documentation.
  • Removed some dead code in Django Middleware that was converting POST body to Json object when it didn't need to.

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some small cleanup

@daveta daveta requested a review from stevengum June 24, 2019 19:51
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some nitpicks but once those are fixed it should be good to go.

@@ -1,5 +1,6 @@
# Copyright (c) Microsoft Corporation. All rights reserved.
# Licensed under the MIT License.
"""Djanjo Application Insights package."""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo here, should be "Django"

@daveta daveta merged commit 10d8825 into master Jun 25, 2019
@daveta daveta deleted the daveta-appinsights-sample branch June 25, 2019 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants