Skip to content

Added depending on streaming to botbuilder-core #1748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 28, 2021
Merged

Added depending on streaming to botbuilder-core #1748

merged 4 commits into from
Jun 28, 2021

Conversation

@tracyboehrer
Copy link
Member

@tracyboehrer tracyboehrer commented Jun 24, 2021

Fixes #1736

@tracyboehrer tracyboehrer requested a review from axelsrz June 24, 2021 21:03
stevengum
stevengum approved these changes Jun 28, 2021
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevengum stevengum merged commit 3a91f0f into main Jun 28, 2021
@stevengum stevengum deleted the tracyboehrer/streaming-depend branch June 28, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@axelsrz axelsrz Awaiting requested review from axelsrz

1 more reviewer

@stevengum stevengum stevengum approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

botbuilder-core library is missing the botframework-streaming dependency

3 participants

@tracyboehrer @stevengum