Skip to content

Add PromptCultureModels, rework prompt locales #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 7, 2021
Merged

Add PromptCultureModels, rework prompt locales #1557

merged 3 commits into from
Apr 7, 2021

Conversation

@mdrichardson
Copy link
Contributor

@mdrichardson mdrichardson commented Mar 4, 2021 •
edited
Loading

Fixes #582

Description

This mainly adjusts Confirm and Choice prompts use of locale to:

  1. Use English as default
  2. Go away from hard-coding the cultures in each prompt to a single source of truth for supported cultures
  3. Accept variations of locale strings ("EN", "en-US", "en-us", etc) (this was an issue in other SDKs for some channels)
  4. Add tests for locales
  5. Also adds support for Italian, Korean, and Turkish, to match published recognizers-text support.

This PR gets these prompts in line with .NET/JS.

Testing

image
image

image
image

@mdrichardson mdrichardson marked this pull request as ready for review March 4, 2021 20:43
@tracyboehrer tracyboehrer merged commit 3afe849 into microsoft:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PORT] Additional Language Support for Confirm/Choice Prompts

2 participants

@mdrichardson @tracyboehrer