Skip to content

Conversation

@axelsrz
Copy link
Member

@axelsrz axelsrz commented Dec 19, 2020

Fixes #1450

@tracyboehrer tracyboehrer merged commit 19b8fb0 into main Jan 5, 2021
@tracyboehrer tracyboehrer deleted the axsuarez/update-msal branch January 5, 2021 19:47
@asdkant-ey
Copy link

asdkant-ey commented Jan 5, 2021

@axelsrz any reason to require a specific version of msal instead of any value in a range (or anything above a certain version? I worry requiring a specific version will trigger this issue again in the future.

@tracyboehrer
Copy link
Member

@asdkant-ey We pin to a specific version to avoid potentially breaking changes by new dependency releases. That is, we've gone through testing with specific versions, and once those dependencies change, you could say it's no longer tested. i.e., We want control of this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dependecy conflict between botframework 4.11.0 and azure-identity 1.5.0

4 participants