Jwiley84/assertnoreply #1273
Merged
Jwiley84/assertnoreply #1273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Odd little story.... I cloned your assert_no_reply branch and the tests pass. Axel did the same with the same result. Weird, right? Because it's failing in DevOps. So... I created a new branch off master, and applied your changes. A test now fails. Like on DevOps. A little digging uncovered that what I cloned does NOT have your changes in them. 100% uncertain how that is the case. I believe... the test that was failing was supposed to throw. In the dotnet version, it does. So I just corrected the test. See test_should_throw_error_with_assert_no_reply_when_no_reply_expected_but_was_received in test_test_adapter.py (under tests). |
|
Thank you! I was hoping I'd have my access back by now so I could correct any flaws. Sorry you had to fix it! |
axelsrz
approved these changes
Jul 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #513