Skip to content

Conversation

@denscollo
Copy link
Contributor

Fixes #1143

Description

  • Add the following events to the TeamsActivityHandler class.
    • teamArchived
    • teamDeleted
    • teamHardDeleted
    • teamRestored
    • teamUnarchived

Note: These changes can't be tested using MS-Teams until the implementation to use these events is done.

Specific Changes

  • Updated teams_activity_handler.py class to add.
    • on_teams_team_archived method.
    • on_teams_team_deleted method.
    • on_teams_team_hard_deleted method.
    • on_teams_team_restored method.
    • on_teams_team_unarchived method.
  • Updated event validations to add teamArchived , teamDeleted , teamHardDeleted , teamRestored and teamUnarchived , calling the previous methods corresponding to each case.
  • Updated test_teams_activity_handler.py class to add the unit tests for the previous methods.

Testing

You can see the added tests running in the following image.
image

santgr11 added 2 commits July 1, 2020 14:56
events added:
- teamArchived
- teamDeleted
- teamHardDeleted
- teamRestored
- teamUnarchived
@tracyboehrer
Copy link
Member

@denscollo You'll need to update from master before I can merge.

@denscollo
Copy link
Contributor Author

@tracyboehrer Done! We just updated the branch. Thanks!

@tracyboehrer
Copy link
Member

tracyboehrer commented Jul 6, 2020

@denscollo This is failing because of pylints insistence on smaller files. Perfectly valid check. In this case, and a few others, we have to live with it.

Under the copyright comments in test_teams_activity_handler.py add:

# pylint: disable=too-many-lines

@tracyboehrer tracyboehrer merged commit 30ccb99 into microsoft:master Jul 6, 2020
@santgr11 santgr11 deleted the southworks/add/teams-events branch July 15, 2020 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional channel/chat lifecycle events (Python)

3 participants