Skip to content

Adding TeamsInfo to on_teams_member_removed #1069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 23, 2020
Merged

Adding TeamsInfo to on_teams_member_removed #1069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a15d9f3
adding TeamInfo to members removed for C# parity'
Virtual-Josh May 15, 2020
492ab5e
singular team
Virtual-Josh May 15, 2020
7fc43ed
Merge branch 'master' into josh/removeMembers
Virtual-Josh May 18, 2020
c4cac78
adding TeamInfo to members removed for C# parity'
Virtual-Josh May 15, 2020
479d22c
resolving conflict
Virtual-Josh May 18, 2020
73aac32
updating unit test
Virtual-Josh May 19, 2020
f55ba68
Merge branch 'master' into josh/removeMembers
axelsrz May 27, 2020
a8347a3
Formatting
axelsrz May 27, 2020
1ae2695
Merge branch 'master' into josh/removeMembers
tracyboehrer Jun 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions libraries/botbuilder-core/botbuilder/core/teams/teams_activity_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -412,10 +412,15 @@ async def on_teams_members_removed_dispatch( # pylint: disable=unused-argument
TeamsChannelAccount().deserialize(new_account_json)
)

return await self.on_teams_members_removed(teams_members_removed, turn_context)
return await self.on_teams_members_removed(
teams_members_removed, team_info, turn_context
)

async def on_teams_members_removed(
self, teams_members_removed: [TeamsChannelAccount], turn_context: TurnContext
async def on_teams_members_removed( # pylint: disable=unused-argument
self,
teams_members_removed: [TeamsChannelAccount],
team_info: TeamInfo,
turn_context: TurnContext,
):
members_removed = [
ChannelAccount().deserialize(member.serialize())
Expand Down
12 changes: 9 additions & 3 deletions libraries/botbuilder-core/tests/teams/test_teams_activity_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,14 @@ async def on_teams_members_added( # pylint: disable=unused-argument
)

async def on_teams_members_removed(
self, teams_members_removed: [TeamsChannelAccount], turn_context: TurnContext
self,
teams_members_removed: [TeamsChannelAccount],
team_info: TeamInfo,
turn_context: TurnContext,
):
self.record.append("on_teams_members_removed")
return await super().on_teams_members_removed(
teams_members_removed, turn_context
teams_members_removed, team_info, turn_context
)

async def on_message_activity(self, turn_context: TurnContext):
Expand Down Expand Up @@ -421,7 +424,10 @@ async def test_on_teams_members_removed_activity(self):
# arrange
activity = Activity(
type=ActivityTypes.conversation_update,
channel_data={"eventType": "teamMemberRemoved"},
channel_data={
"eventType": "teamMemberRemoved",
"team": {"id": "team_id_1", "name": "new_team_name"},
},
members_removed=[
ChannelAccount(
id="123",
Expand Down