NumberPrompt Locale Not Fully Implemented

[Zerryth]

Version

v4.5

Describe the bug

Found this bug while investigating for parity with regards to this NumberPrompt bug filed in the dotnet repo

• in constructor, default_locale attribute is set, but never used in NumberPrompt's implementation (not in on_prompt() nor on_recognize()

• on_recognize() does allow you to pass in locale via Activity, however locale will not be used if only default_locale is specified

• "English" is used as string to specify locale, when we should be using the constants provided by the python recognizers-text repo

• Separately, there's definitely a lack of unit test coverage for this feature (only 2 tests written)

Expected behavior

• implement use of default_locale
• implement use of recognizers-text constants to specify locale

[bug]

[Zerryth]

Update: looks like python actually never parses the value from str to float/int in NumberPrompt, which deviates from the behavior in dotnet repo.

This bug should be fixed as well.

Python:

            results = recognize_number(message.text, culture)
            if results:
                result.succeeded = True
                result.value = results[0].resolution["value"]