Skip to content

CloudAdapter.continue_conversation() is missing bot_app_id parameter #2036

@kostyaplis

Description

@kostyaplis

Version

4.14.6

Describe the bug

Posting a message in a group chat throws an exception

To Reproduce

adapter = CloudAdapter(ConfigurationBotFrameworkAuthentication(config))

conversation_reference = ConversationReference(
    service_url=config.BASE_URL,
    channel_id="msteams",
    conversation=ConversationAccount(
        id=${CHAT_ID},
        is_group = True,
    ),
)
await adapter.continue_conversation(
    reference=conversation_reference,
    callback=lambda turn_context: turn_context.send_activity("Hello!"),
)

Exception:

Traceback (most recent call last):
  *** removed for brevity ****
    result = await adapter.continue_conversation(
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/konstantinplis/.pyenv/versions/3.11.0/lib/python3.11/site-packages/botbuilder/core/cloud_adapter_base.py", line 165, in continue_conversation
    return await self.process_proactive(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/konstantinplis/.pyenv/versions/3.11.0/lib/python3.11/site-packages/botbuilder/core/cloud_adapter_base.py", line 262, in process_proactive
    connector_client = await connector_factory.create(
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/konstantinplis/.pyenv/versions/3.11.0/lib/python3.11/site-packages/botframework/connector/auth/_connector_factory_impl.py", line 37, in create
    credentials = await self._credential_factory.create_credentials(
                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Users/konstantinplis/.pyenv/versions/3.11.0/lib/python3.11/site-packages/botframework/connector/auth/password_service_client_credential_factory.py", line 35, in create_credentials
    raise Exception("Invalid app_id")
Exception: Invalid app_id

Expected behavior

Message sent

Additional context

It seems that bot_app_id must be passed to CloudAdapter.continue_conversation() and subsequently to create_claims_identity(bot_app_id)

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugIndicates an unexpected problem or an unintended behavior.needs-triageThe issue has just been created and it has not been reviewed by the team.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions