Skip to content

botbuilder-testing is missing install requirements #1627

@cas--

Description

@cas--

Version

botbuilder-testing 4.12.0

Describe the bug

While installing botbuilder-testing for CI I got errors about missing dependencies.

To Reproduce

  1. python3 -m venv .venv
  2. . .venv/bin/activate
  3. pip install -U pip wheel
  4. pip install botbuilder-testing
  5. python -c "from botbuilder.testing import DialogTestClient"

First error is missing pytest:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/home/calum/sureswift/jell/jell-bot-teams-v2/.venv-test/lib/python3.8/site-packages/botbuilder/testing/__init__.py", line 6, in <module>
    from .storage_base_tests import StorageBaseTests
  File "/home/calum/sureswift/jell/jell-bot-teams-v2/.venv-test/lib/python3.8/site-packages/botbuilder/testing/storage_base_tests.py", line 26, in <module>
    import pytest
ModuleNotFoundError: No module named 'pytest'
  1. pip install pytest
  2. python -c 'from botbuilder.testing import DialogTestClient'

Next error is missing botbuilder-azure:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/calum/sureswift/jell/jell-bot-teams-v2/.venv-test/lib/python3.8/site-packages/botbuilder/testing/__init__.py", line 6, in <module>
    from .storage_base_tests import StorageBaseTests
  File "/home/calum/sureswift/jell/jell-bot-teams-v2/.venv-test/lib/python3.8/site-packages/botbuilder/testing/storage_base_tests.py", line 27, in <module>
    from botbuilder.azure import CosmosDbStorage
ModuleNotFoundError: No module named 'botbuilder.azure'
  1. pip install botbuilder-azure
  2. python -c 'from botbuilder.testing import DialogTestClient'

Command works!

Expected behavior

No errors after installing botbuilder-testing and importing module

I do wonder if the requirement for pytest is not necessary, leaving the lib test-suite agnostic and could be refactored out?

Metadata

Metadata

Labels

Bot ServicesRequired for internal Azure reporting. Do not delete. Do not change color.bugIndicates an unexpected problem or an unintended behavior.customer-replied-toIndicates that the team has replied to the issue reported by the customer. Do not delete.customer-reportedIssue is created by anyone that is not a collaborator in the repository.needs-triageThe issue has just been created and it has not been reviewed by the team.

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions