Skip to content

The ConversationAccount doesn't have activity_id #127

@TonyMengg

Description

@TonyMengg

Version

4.0

Describe the bug

In the bot_framework_adapter.py, update_activity method:

        try:
            client = self.create_connector_client(activity.service_url)
            return await client.conversations.update_activity_async(
                activity.conversation.id,
                activity.conversation.activity_id,
                activity)
        except Exception as e:
            raise e

The second parameter passed in the function seems wrong, the conversation is a type of ConversationAccount, which doesn't have activity_id attribute at all.

To Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

It should be

        try:
            client = self.create_connector_client(activity.service_url)
            return await client.conversations.update_activity_async(
                activity.conversation.id,
                activity.id,
                activity)
        except Exception as e:
            raise e

Screenshots

If applicable, add screenshots to help explain your problem.

Additional context

Add any other context about the problem here.

[bug]

Metadata

Metadata

Assignees

Labels

P1Painful if we don't fix, won't block releasing

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions