Filter continueConversation events when logging #2903
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshgummersall
requested review from
EricDahlvang,
Stevenic,
carlosscastro,
johnataylor and
stevengum
as code owners
joshgummersall
commented
Oct 14, 2020
| }).use(new TranscriptLoggerMiddleware(new SyncErrorLogger())); | ||
|
|
||
| adapter.send('test'); | ||
| describe("'s error handling", function () { |
There was a problem hiding this comment.
For reference, this is the major test refactor portion.
joshgummersall
force-pushed
the
joshgummersall/filter-continue-conversation-events
branch
from
d448d37 to
d7d764c
Compare
joshgummersall
force-pushed
the
joshgummersall/filter-continue-conversation-events
branch
from
d7d764c to
2311b83
Compare
stevengum
reviewed
Oct 19, 2020
stevengum
requested changes
Oct 19, 2020
There was a problem hiding this comment.
For the actual values of constants, enums, etc we do stay aligned with what's used in C#/other languages. Once the .NET PR lands the The ActivityEventNames enum in JS should match what's in .NET. Other than that, the PR looks solid!
As a general rule, if it's a value that might be serialized and could be shared across languages, it should be aligned across all languages.
joshgummersall
deleted the
joshgummersall/filter-continue-conversation-events
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805
This PR also includes a small test refactoring to use
sinonfor mocking and verifying error handling. It's a more natural way to set up expectations and verify them without patching methods. It was a bit of bikeshedding, but it should serve as a useful example for future testing scenarios.