Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

Conversation

@denscollo
Copy link

Fixes #622

Description

This pull request adds the linkToMessage property to the MessageActionsPayload class from BotBuilder-Schema library. By adding this property, it can add the link provided in the payload from MS-Teams.
Also, we added tests for the methods of the class.

Specific Changes

  • Added the linkToMessage property to the MessageActionsPayload class from BotBuilder-Schema
  • Created the MessageActionsPayloadTest.java file inside the test/teams folder of the library.
  • Added tests for all the methods of the MessageActionsPayload in that test class.

Testing

In the following image, you can see the bot assigns the linkToMessage property when sharing a card in MS-Teams, using the 51.teams-messaging-extensions-action sample from the same repository.
image

And in the next image, you can see the added tests passing.
image

@tracyboehrer
Copy link
Member

@JuanAr @santgr11 While not at all obvious, this PR is failing the build check due to some CheckStyle errors in Schema. If you perform a "mvn package" from the Java SDK root, it should generate a checkstyle-result.xml or pmd.xml in the libraries/botbuilder-schema/target folder.

@denscollo
Copy link
Author

Thanks @tracyboehrer, we were reviewing the logs to find what the issue was. We'll work on this to have the PR ready. Thanks

@tracyboehrer
Copy link
Member

@denscollo Thanks! This issue is on my list of things to correct. It throws everyone. I believe there is a way to make those errors more obvious without having to dig into the DevOps logs.

@denscollo
Copy link
Author

@tracyboehrer We just pushed the styling fix and the build succedeed! Thanks 😄

@tracyboehrer tracyboehrer merged commit 947b4e7 into microsoft:master Jun 25, 2020
@tracyboehrer tracyboehrer added this to the R10 milestone Aug 17, 2020
@Batta32 Batta32 deleted the southworks/add/linkToMessage branch December 1, 2020 19:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add linkToMessage to the MessageActionsPayload object (Java)

4 participants