Skip to content
This repository was archived by the owner on Dec 4, 2023. It is now read-only.
This repository was archived by the owner on Dec 4, 2023. It is now read-only.

[PORT] Fix LuisRecognizer to not return intents if there is no utterance #626

@tomlm

Description

@tomlm

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#4129

Fixes #4117

Description

Luis Recognizer returns an intent of string.empty with a perfect score of 1.0. This messes up logic downstream in RecognizerSet because it thinks it has a perfect intent.

Specific Changes

  • Changed LuisRecognizer to return empy RecognizerResult (no intents or entities) when there is no utterance.

Testing

Changed RegexRecognizer to behave just like LuisRecognizer so that ValueRecognizer tests are valid check.

Changed projects

  • Microsoft.Bot.Builder.AI.LUIS
  • Microsoft.Bot.Builder.Dialogs.Adaptive
  • Microsoft.Bot.Builder.AI.LUIS.Tests

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions