Skip to content

Support bot sdk dot net for targeted meeting notification #6570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 21, 2022
Merged

Support bot sdk dot net for targeted meeting notification #6570

merged 4 commits into from
Dec 21, 2022

Conversation

@yingduyingdu
Copy link
Contributor

@yingduyingdu yingduyingdu commented Dec 15, 2022 •
edited
Loading

Description

This feature aims to extend the dot Net Bot SDK so that developers can send targeted meeting notifications in Microsoft Teams meetings.

Add TeamsInfo.SendMeetingNotificationAsync

Closes #6571

Changes

Microsoft.Bot.Builder/Teams

  • add SendMeetingNotificationAsync method in TeamsInfo.cs

Microsoft.Bot.Connector/Teams

  • Construct and send meeting notification request

Microsft.Bot.Schema/Teams

  • Create classes for Teams meeting notification

Testing

Test SendMeetingNotificationAsync for different status codes in TeamsInfoTests.cs.

@yingduyingdu yingduyingdu requested a review from a team as a code owner December 15, 2022 18:10
@yingduyingdu yingduyingdu self-assigned this Dec 15, 2022
@yingduyingdu yingduyingdu added the Automation: No parity PR does not need to be applied to other languages. label Dec 15, 2022
singhk97
singhk97 reviewed Dec 15, 2022
View reviewed changes
libraries/Microsoft.Bot.Builder/Teams/TeamsInfo.cs
}

/// <summary>
/// Sends a notification to meeting participants. This functionality is available only in teams meeting scoped conversations.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that this feature won't work in a group chat meeting?

singhk97
singhk97 reviewed Dec 15, 2022
View reviewed changes
@singhk97
Copy link

singhk97 commented Dec 15, 2022 •
edited by yingduyingdu
Loading

Pull Request Test Coverage Report for Build 333683

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 56 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.009%) to 79.054%

Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Connector/Teams/TeamsOperationsExtensions.cs 1 85.71%
/libraries/Microsoft.Bot.Builder/Teams/TeamsInfo.cs 12 71.76%
/libraries/Microsoft.Bot.Connector/Teams/TeamsOperations.cs 43 59.9%
Totals Coverage Status
Change from base Build 332211: -0.009%
Covered Lines: 25800
Relevant Lines: 32636

💛 - Coveralls

Does it make sense to fix the missed lines with unit tests?

Hi @singhk97 , according to previous code coverage in the same class, we don't write unit test for trace report and throw exception.

singhk97
singhk97 reviewed Dec 16, 2022
View reviewed changes
@yingduyingdu yingduyingdu force-pushed the yingdu/meetingNotification branch from a5268f5 to 468c6df Compare December 16, 2022 19:33
@microsoft microsoft deleted a comment from coveralls Dec 16, 2022
@johnataylor
Copy link
Member

/azp run BotBuilder-DotNet-CI-PR-(MacLinux)-yaml

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

johnataylor
johnataylor suggested changes Dec 20, 2022
View reviewed changes
Copy link
Member

@johnataylor johnataylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the comment style. We don't want C style comments.

I have some minor comments on the code, but what you have is consistent with the old generated code so I think we can leave it.

libraries/Microsoft.Bot.Connector/Teams/TeamsOperations.cs Outdated

if ((int)statusCode == 207)
{
/* 207: if the notifications are sent only to parital number of recipients because
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use C style comments /* */ just use //

libraries/Microsoft.Bot.Connector/Teams/TeamsOperations.cs Outdated
}
else if ((int)statusCode != 202)
{
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use C style comments /* */ just use //

tests/Microsoft.Bot.Builder.Tests/Teams/TeamsInfoTests.cs Outdated
[InlineData("403")]
public async Task TestSendMeetingNotificationAsync(string statusCode)
{
/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use C style comments /* */ just use //

@johnataylor
Copy link
Member

@yingduyingdu I've made the Mac build pipeline optional for this PR, so it's not blocking, we'll fix the pipeline week after next.

@yingduyingdu yingduyingdu force-pushed the yingdu/meetingNotification branch from 468c6df to d07ec16 Compare December 20, 2022 21:31
@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

@yingduyingdu yingduyingdu merged commit 74a8612 into main Dec 21, 2022
@yingduyingdu yingduyingdu deleted the yingdu/meetingNotification branch December 21, 2022 07:30
@Amrit10737726 Amrit10737726 mentioned this pull request Aug 6, 2024
Closed
@gandiddi gandiddi mentioned this pull request Sep 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

2 more reviewers

@singhk97 singhk97 singhk97 left review comments

@johnataylor johnataylor johnataylor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@yingduyingdu yingduyingdu

Labels

Automation: No parity PR does not need to be applied to other languages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Bot SDK Dot Net for Targeted Meeting Notification

4 participants

@yingduyingdu @singhk97 @johnataylor @BruceHaley