-
Notifications
You must be signed in to change notification settings - Fork 492
Update TeamsInfo to support CloudAdapter #5728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| /// <summary> | ||
| /// Creates a new thread in a team chat and sends an activity to that new thread. | ||
| /// </summary> | ||
| /// <param name="turnContext"> Turn context. </param> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: spacing looks odd before/after the param comments here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need to revisit this when we add support for create conversation from a skill. This will probably require audience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the descriptions got mixed up - the description for activity is the channel ID, and channel ID has a fragment of "cancellation token." (in the code comments)
|
Thanks @clearab nice catch. That must have been there for ages - I updated the old functions description too. |
Pull Request Test Coverage Report for Build 254556
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
fixes #5685