Skip to content

Conversation

@johnataylor
Copy link
Member

fixes #5685

@johnataylor johnataylor requested a review from a team as a code owner June 23, 2021 23:46
@johnataylor johnataylor changed the title Johtaylo/issue5685 Update TeamsInfo to support CloudAdapter Jun 24, 2021
/// <summary>
/// Creates a new thread in a team chat and sends an activity to that new thread.
/// </summary>
/// <param name="turnContext"> Turn context. </param>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: spacing looks odd before/after the param comments here

Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to revisit this when we add support for create conversation from a skill. This will probably require audience.

Copy link

@clearab clearab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the descriptions got mixed up - the description for activity is the channel ID, and channel ID has a fragment of "cancellation token." (in the code comments)

@johnataylor
Copy link
Member Author

Thanks @clearab nice catch. That must have been there for ages - I updated the old functions description too.

@coveralls
Copy link
Collaborator

coveralls commented Jun 24, 2021

Pull Request Test Coverage Report for Build 254556

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 15 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 76.168%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 93.94%
/libraries/Microsoft.Bot.Builder/Teams/TeamsInfo.cs 14 72.22%
Totals Coverage Status
Change from base Build 254530: -0.02%
Covered Lines: 23056
Relevant Lines: 30270

💛 - Coveralls

Copy link
Contributor

@mrivera-ms mrivera-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

Copy link
Contributor

@mrivera-ms mrivera-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TeamsInfo should work with CloudAdapter

5 participants