Skip to content

Add OnInstallationUpdateActivity in adaptive trigger conditions #4629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 19, 2020
Merged

Add OnInstallationUpdateActivity in adaptive trigger conditions #4629

merged 8 commits into from
Sep 19, 2020

Conversation

@feich-ms
Copy link
Contributor

@feich-ms feich-ms commented Sep 11, 2020 •
edited
Loading

Fixes #4400 to add OnInstallationUpdateActivity in adaptive trigger conditions

Description

add OnInstallationUpdateActivity in adaptive trigger conditions and register it.

Specific Changes

Testing

test added

@feich-ms feich-ms marked this pull request as ready for review September 11, 2020 09:32
@feich-ms feich-ms requested a review from a team as a code owner September 11, 2020 09:32
@feich-ms feich-ms changed the title add OnInstallationUpdateActivity and related tests add OnInstallationUpdateActivity in adaptive trigger conditions Sep 11, 2020
@boydc2014 boydc2014 added Area: Adaptive The issue is related to Adaptive dialogs P1 Painful if we don't fix, won't block releasing labels Sep 14, 2020
@boydc2014 boydc2014 changed the title add OnInstallationUpdateActivity in adaptive trigger conditions Add OnInstallationUpdateActivity in adaptive trigger conditions Sep 14, 2020
@feich-ms feich-ms requested a review from a team as a code owner September 16, 2020 04:46
@feich-ms
Copy link
Contributor Author

feich-ms commented Sep 16, 2020

@EricDahlvang could you please help to review if you have time?

tomlm
tomlm approved these changes Sep 18, 2020
View reviewed changes
Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@mrivera-ms mrivera-ms merged commit 31af94b into main Sep 19, 2020
@mrivera-ms mrivera-ms deleted the feich/add_adaptive_action_for_installationUpdate branch September 19, 2020 05:34
@chon219 chon219 mentioned this pull request Nov 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EricDahlvang EricDahlvang Awaiting requested review from EricDahlvang

@boydc2014 boydc2014 Awaiting requested review from boydc2014

@chrimc62 chrimc62 Awaiting requested review from chrimc62

1 more reviewer

@tomlm tomlm tomlm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Area: Adaptive The issue is related to Adaptive dialogs P1 Painful if we don't fix, won't block releasing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add Adaptive Action for InstallationUpdate invoke (not Teams specific)

5 participants

@feich-ms @tomlm @boydc2014 @mrivera-ms