Skip to content

Fix LuisRecognizer to not return intents if there is no utterance #4129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2020
Merged

Fix LuisRecognizer to not return intents if there is no utterance #4129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9c6196
If there is no utterance we should return no intents.
Jun 18, 2020
fc2a8b1
update regexrecognizer to return no intents if there is no utterance …
Jun 18, 2020
000a926
update oracle tests
Jun 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizerOptionsV2.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,9 +62,7 @@ internal override async Task<RecognizerResult> RecognizeInternalAsync(ITurnConte
{
recognizerResult = new RecognizerResult
{
Text = utterance,
Intents = new Dictionary<string, IntentScore>() { { string.Empty, new IntentScore() { Score = 1.0 } } },
Entities = new JObject(),
Text = utterance
};
}
else
Expand Down
4 changes: 1 addition & 3 deletions libraries/Microsoft.Bot.Builder.AI.LUIS/LuisRecognizerOptionsV3.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,7 @@ private async Task<RecognizerResult> RecognizeAsync(ITurnContext turnContext, st
{
recognizerResult = new RecognizerResult
{
Text = utterance,
Intents = new Dictionary<string, IntentScore>() { { string.Empty, new IntentScore() { Score = 1.0 } } },
Entities = new JObject(),
Text = utterance
};
}
else
Expand Down
7 changes: 6 additions & 1 deletion libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Recognizers/RegexRecognizer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,13 @@ public override async Task<RecognizerResult> RecognizeAsync(DialogContext dialog
var recognizerResult = new RecognizerResult()
{
Text = text,
Intents = new Dictionary<string, IntentScore>(),
};

if (string.IsNullOrWhiteSpace(text))
{
// nothing to recognize, return empty recognizerResult
return recognizerResult;
}

// add entities from regexrecgonizer to the entities pool
var entityPool = new List<Entity>();
Expand Down
4 changes: 1 addition & 3 deletions tests/Microsoft.Bot.Builder.AI.LUIS.Tests/LuisOracleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,9 +138,7 @@ public async Task NullUtterance()
Assert.IsNull(result.AlteredText);
Assert.AreEqual(utterance, result.Text);
Assert.IsNotNull(result.Intents);
Assert.AreEqual(1, result.Intents.Count);
Assert.IsNotNull(result.Intents[string.Empty]);
Assert.AreEqual(result.GetTopScoringIntent(), (string.Empty, 1.0));
Assert.AreEqual(0, result.Intents.Count);
Assert.IsNotNull(result.Entities);
Assert.AreEqual(0, result.Entities.Count);
}
Expand Down
4 changes: 1 addition & 3 deletions tests/Microsoft.Bot.Builder.AI.LUIS.Tests/LuisV3OracleTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,9 +108,7 @@ public async Task NullUtterance()
Assert.IsNull(result.AlteredText);
Assert.AreEqual(utterance, result.Text);
Assert.IsNotNull(result.Intents);
Assert.AreEqual(1, result.Intents.Count);
Assert.IsNotNull(result.Intents[string.Empty]);
Assert.AreEqual(result.GetTopScoringIntent(), (string.Empty, 1.0));
Assert.AreEqual(0, result.Intents.Count);
Assert.IsNotNull(result.Entities);
Assert.AreEqual(0, result.Entities.Count);
}
Expand Down