Skip to content

Conversation

@EricDahlvang
Copy link
Member

Fixes #2956

and

#3039

@coveralls
Copy link
Collaborator

coveralls commented Jan 4, 2020

@fuselabs
Copy link
Collaborator

fuselabs commented Jan 4, 2020

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.Luis.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.AI.QnA.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.ApplicationInsights.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Azure.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Dialogs.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.ApplicationInsights.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Integration.AspNet.Core.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.TemplateManager.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.Testing.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Configuration.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Connector.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll compared against version 4.6.3
✔️ No Binary Compatibility issues for Microsoft.Bot.Streaming.dll compared against version 4.6.3

Copy link
Contributor

@tomlm tomlm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jackdeesun
Copy link

Hi Eric, I am using bot framework 4.7.2 (from NuGet) and i coudln't find below 2 properties in Microsoft.Bot.Builder.Dialogs.Choices.FindChoicesOptions class. Could you please help me on this.
Props Name: RecognizeNumbers and RecognizeOrdinals

@EricDahlvang
Copy link
Member Author

Hi @jackdeesun

4.7.2 does not contain the RecognizeNumbers and RecognizeOrdinals flags: https://github.com/microsoft/botbuilder-dotnet/blob/4.7/libraries/Microsoft.Bot.Builder.Dialogs/Choices/FindChoicesOptions.cs

These changes should be released with 4.8 in a few weeks. If you need this now, the bits are available on the myget daily build: https://botbuilder.myget.org/feed/botbuilder-v4-dotnet-daily/package/nuget/Microsoft.Bot.Builder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ChoicePrompt handles irrelevant utterance as a choice because of ordinals/numbers

6 participants