Skip to content

Migrating to Node 18 #841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from
Closed

Migrating to Node 18 #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
20f1b6c
release for 4 version
May 30, 2022
8a02689
update pipeline
May 30, 2022
ad3e4f0
update package.json
May 30, 2022
5746751
fix test and build commands
May 31, 2022
6487ca4
fixed tests on node18
Jun 2, 2022
4b0a00d
temporary commit to enable CI
Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 13 additions & 12 deletions azure-pipelines.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ trigger:
- master
- features/*
- releases/*
- users/v-andivanov/release-4

jobs:
#################################################
Expand All @@ -23,11 +24,11 @@ jobs:
command: install
workingDir: node

# use node 10
# use node 18
- task: NodeTool@0
displayName: (azure-pipelines-task-lib) use node 10.23.0
displayName: (azure-pipelines-task-lib) use node 18.2.0
inputs:
versionSpec: "10.23.0"
versionSpec: "18.2.0"

# build/test
- script: |
Expand Down Expand Up @@ -70,20 +71,20 @@ jobs:
################################################################################
# azure-pipelines-task-lib
################################################################################

# npm install
- task: Npm@1
displayName: (azure-pipelines-task-lib) npm install
inputs:
command: install
workingDir: node

# use node 10
# use node 18
- task: NodeTool@0
displayName: (azure-pipelines-task-lib) use node 10.23.0
displayName: (azure-pipelines-task-lib) use node 18.2.0
inputs:
versionSpec: "10.23.0"
versionSpec: "18.2.0"

# build/test
- script: node make.js test
workingDirectory: node
Expand All @@ -101,7 +102,7 @@ jobs:
npm publish || true # Ignore publish failures, usually will happen because package already exists
displayName: (azure-pipelines-task-lib) npm publish
workingDirectory: node
condition: and(succeeded(), in(variables['build.reason'], 'IndividualCI', 'BatchedCI', 'Manual'), in(variables['build.sourcebranchname'], 'master', 'releases/3.x'))
condition: and(succeeded(), in(variables['build.reason'], 'IndividualCI', 'BatchedCI', 'Manual'), in(variables['build.sourcebranchname'], 'master'))
env:
NPM_TOKEN: $(npmPublishToken)

Expand All @@ -124,11 +125,11 @@ jobs:
command: install
workingDir: node

# use node 10
# use node 18
- task: NodeTool@0
displayName: (azure-pipelines-task-lib) use node 10.23.0
displayName: (azure-pipelines-task-lib) use node 18.2.0
inputs:
versionSpec: "10.23.0"
versionSpec: "18.2.0"

# build/test
- script: node make.js test
Expand Down
2 changes: 1 addition & 1 deletion node/buildutils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ exports.getExternals = function () {
// and add node to the PATH
var nodeUrl = process.env['TASK_NODE_URL'] || 'https://nodejs.org/dist';
nodeUrl = nodeUrl.replace(/\/$/, ''); // ensure there is no trailing slash on the base URL
var nodeVersion = 'v10.23.0';
var nodeVersion = 'v18.2.0';
switch (platform) {
case 'darwin':
var nodeArchivePath = downloadArchive(nodeUrl + '/' + nodeVersion + '/node-' + nodeVersion + '-darwin-x64.tar.gz');
Expand Down
Loading