Skip to content

Conversation

@brcrista
Copy link
Contributor

@brcrista brcrista commented Mar 16, 2018

These are all the commands that are looked up in MockAnswers in mock-task and mock-toolrunner.
With this change, we should stop using type assertions to force the TaskLibAnswers type when we set up the mocks for our L0 tests.
This will allow test authors to catch commands they think are being mocked but are not.

Copy link
Contributor

@madhurig madhurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@brcrista
Copy link
Contributor Author

Someone will have to merge this once it has sign off. I don't have write permissions for this repo.

@stephenmichaelf
Copy link
Member

LGTM

@stephenmichaelf stephenmichaelf merged commit 54cba4e into microsoft:master Mar 21, 2018
fullstackinfo pushed a commit to fullstackinfo/azure-pipelines-task-lib that referenced this pull request Aug 17, 2024
* Add supported commands to TaskLibAnswers

* Remove stray semicolon

* Typescript -> TypeScript
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants