add optional parameter to getHttpProxyConfig allow bypass filter. #324
+21
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node/task.ts
Outdated
| }; | ||
| let bypass: boolean = false; | ||
| if (requestUrl) { | ||
| this._httpProxyBypassHosts.forEach(bypassHost => { |
Member
There was a problem hiding this comment.
Didn't see this in the code? How is this different than proxyBypassHosts?
Contributor
There was a problem hiding this comment.
Does that include wildcards, ip ranges etc as well?
Contributor
There was a problem hiding this comment.
it's a list of regex patterns
keithrob
reviewed
Mar 6, 2018
| * @return ProxyConfiguration | ||
| */ | ||
| export function getHttpProxyConfiguration(): ProxyConfiguration { | ||
| export function getHttpProxyConfiguration(requestUrl?: string): ProxyConfiguration { |
Contributor
Author
There was a problem hiding this comment.
i might just leave it as string since the bypass list is always an array of strings. :D
Contributor
There was a problem hiding this comment.
OK, You could do requestUrl.host if it was a URL() though.
keithrob
approved these changes
Mar 8, 2018
Contributor
|
@TingluoHuang, |
Contributor
|
Plan is to click merge which I just did. |
Contributor
|
@bryanmacfarlane, |
Contributor
|
:) |
fullstackinfo
pushed a commit
to fullstackinfo/azure-pipelines-task-lib
that referenced
this pull request
Aug 17, 2024
…crosoft#324) * add optional parameter to getHttpProxyConfig allow bypass filter. * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested.