Skip to content

remove extra schema info #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2018
Merged

remove extra schema info #308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 2 additions & 53 deletions tasks.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,17 +29,6 @@
"author": {
"type": "string"
},
"visibility": {
Copy link
Member

@AArnott AArnott Mar 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericsciple We have some tasks that define this property today. Should we drop it? Is it completely ignored at this point?

Copy link
Contributor Author

@ericsciple ericsciple Mar 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preview is definitely not correct.

I think release ignores the visibility rules, and build does not.

most tasks should run on either, so i think it generally should not be required. we'll probably stop filtering in build, and rely on task authors failing gracefully at runtime.

"type": "array",
"items": {
"type": "string",
"enum": [
"Build",
"Release",
"Preview"
]
}
},
"runsOn": {
"type": "array",
"items": {
Expand Down Expand Up @@ -81,15 +70,6 @@
},
"isExpanded": {
"type": "boolean"
},
"tags": {
"type": "array",
"items": {
"type": "string",
"enum": [
"Preview"
]
}
}
}
}
Expand All @@ -108,7 +88,7 @@
"version": {
"type": "object",
"additionalProperties": false,
"description": "Always update this when you release your task, so that the agents utilise the latest code.",
"description": "Always update this when you release your task, so that the agents utilize the latest code.",
"required": [
"Major",
"Minor",
Expand Down Expand Up @@ -196,7 +176,7 @@
"properties": {
"type": "object",
"properties": {
"EditableOptions": {
"editableOptions": {
"type": "string",
"enum": [
"True",
Expand Down Expand Up @@ -268,26 +248,8 @@
"Node": {
"$ref": "#/definitions/executionObject"
},
"Bash": {
"$ref": "#/definitions/executionObject"
},
"AzurePowerShell": {
"$ref": "#/definitions/executionObject"
},
"PowerShell": {
"$ref": "#/definitions/executionObject"
},
"PowerShell3": {
"$ref": "#/definitions/executionObject"
},
"PowerShellExe": {
"$ref": "#/definitions/executionObject"
},
"Process": {
"$ref": "#/definitions/executionObject"
},
"RM:ManualIntervention": {
"$ref": "#/definitions/executionObject"
}
}
},
Expand All @@ -307,19 +269,6 @@
"type": "string",
"description": "The target file to be executed. You can use variables here in brackets e.g. $(currentDirectory)\filename.ps1"
},
"argumentFormat": {
"type": "string"
},
"workingDirectory": {
"type": "string",
"description": "The directory to execute the task from e.g. $(currentDirectory)"
},
"modifyEnvironment": {
"type": [
"boolean",
"string"
]
},
"platforms": {
"type": "array",
"items": {
Expand Down